Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fallback values for user created via ID token #3467

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Set fallback values for user created via ID token #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df2cda9
Set fallback values for user created by ID-Token
fraxachun Feb 19, 2025
2c016a7
Add changeset
fraxachun Feb 19, 2025
fa85e21
Improve changeset
johnnyomair Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-bees-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-api": patch
---

Add fallback values for users created via ID token
4 changes: 2 additions & 2 deletions packages/api/cms-api/src/user-permissions/user-permissions.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ export class UserPermissionsService {
if (!idToken.sub) throw new Error("JwtPayload does not contain sub.");
return {
id: idToken.sub,
name: idToken.name,
email: idToken.email,
name: idToken.name || "Unknown User",
email: idToken.email || "",
};
}

Expand Down