Allow overriding requestHandler in BlobStorageS3Storage
#2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f951f8a to
6906be1
Compare
dkarnutsch
previously approved these changes
Nov 5, 2024
dkarnutsch
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows overriding the requestHandler of the S3 client. Also the versions of
@aws-sdk/client-s3and@smithy/node-http-handlerare fixed to avoid issue smithy-lang/smithy-typescript#1443.Motivation
We are facing problems in customer projects when streaming videos. It seems that the socket connections are never closed when streaming a video from the S3 bucket. I want to override the requestHandler to debug this. This allows me to set custom timeouts and maxSockets (https://github.com/aws/aws-sdk-js-v3/blob/main/supplemental-docs/CLIENTS.md#request-handler-requesthandler).