Fix display of warnings for forms that use both form-level and field-…

…level validation (#3263)
vivid-planet · Feb 19, 2025 · faa54eb · faa54eb
1 parent 457c62d
commit faa54eb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/famous-pianos-happen.md b/.changeset/famous-pianos-happen.md
@@ -0,0 +1,5 @@
+---
+"@comet/admin": patch
+---
+
+Fix display of warnings for forms that use both form-level and field-level validation
diff --git a/packages/admin/admin/src/FinalForm.tsx b/packages/admin/admin/src/FinalForm.tsx
@@ -162,6 +162,8 @@ export function FinalForm<FormValues = AnyObject, InitialFormValues = Partial<Fo
 
         const registeredFields = formRenderProps.form.getRegisteredFields();
 
+        const formLevelWarnings = useRef<Record<string, string | undefined>>({});
+
         useEffect(() => {
             if (validateWarning) {
                 const validate = async () => {
@@ -177,11 +179,17 @@ export function FinalForm<FormValues = AnyObject, InitialFormValues = Partial<Fo
 
                     if (!validationWarnings) {
                         registeredFields.forEach((fieldName) => {
-                            setFieldData(fieldName, { warning: undefined });
+                            const hasFormLevelWarning = Boolean(formLevelWarnings.current[fieldName]);
+                            if (hasFormLevelWarning) {
+                                setFieldData(fieldName, { warning: undefined });
+                            }
                         });
+                        formLevelWarnings.current = {};
                         return;
                     }
 
+                    formLevelWarnings.current = validationWarnings;
+
                     Object.entries(validationWarnings).forEach(([fieldName, warning]) => {
                         setFieldData(fieldName, { warning });
                     });