From 6b0ecebedadfc0184f99f4816b3e99a97ff03836 Mon Sep 17 00:00:00 2001
From: Daniel Karnutsch <dkarnutsch@users.noreply.github.com>
Date: Fri, 25 Oct 2024 10:51:32 +0200
Subject: [PATCH] DAM: Fix/set cache-control headers (#2653)

---
 .changeset/real-lizards-drum.md                      |  8 ++++++++
 .../api/cms-api/src/dam/files/files.controller.ts    |  8 ++++----
 .../api/cms-api/src/dam/images/images.controller.ts  | 12 ++++++++----
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 .changeset/real-lizards-drum.md

diff --git a/.changeset/real-lizards-drum.md b/.changeset/real-lizards-drum.md
new file mode 100644
index 0000000000..6ee01d80bc
--- /dev/null
+++ b/.changeset/real-lizards-drum.md
@@ -0,0 +1,8 @@
+---
+"@comet/cms-api": patch
+---
+
+DAM: Fix/set cache-control headers
+
+-   Public endpoints should cache files for 1 day
+-   Private endpoints should cache files for 1 year - but only in local caches (not CDN)
diff --git a/packages/api/cms-api/src/dam/files/files.controller.ts b/packages/api/cms-api/src/dam/files/files.controller.ts
index b21be05d4a..31d2978a39 100644
--- a/packages/api/cms-api/src/dam/files/files.controller.ts
+++ b/packages/api/cms-api/src/dam/files/files.controller.ts
@@ -109,7 +109,7 @@ export function createFilesController({ Scope: PassedScope }: { Scope?: Type<Dam
                 throw new ForbiddenException();
             }
 
-            return this.streamFile(file, res, { range, overrideHeaders: { "Cache-control": "private" } });
+            return this.streamFile(file, res, { range, overrideHeaders: { "cache-control": "max-age=31536000, private" } }); // Local caches only (1 year)
         }
 
         @Get(`/download/preview/${fileUrl}`)
@@ -130,7 +130,7 @@ export function createFilesController({ Scope: PassedScope }: { Scope?: Type<Dam
             }
 
             res.setHeader("Content-Disposition", "attachment");
-            return this.streamFile(file, res, { range, overrideHeaders: { "Cache-control": "private" } });
+            return this.streamFile(file, res, { range, overrideHeaders: { "cache-control": "max-age=31536000, private" } }); // Local caches only (1 year)
         }
 
         @DisableCometGuards()
@@ -147,7 +147,7 @@ export function createFilesController({ Scope: PassedScope }: { Scope?: Type<Dam
             }
 
             res.setHeader("Content-Disposition", "attachment");
-            return this.streamFile(file, res, { range });
+            return this.streamFile(file, res, { range, overrideHeaders: { "cache-control": "max-age=86400, public" } }); // Public cache (1 day)
         }
 
         @DisableCometGuards()
@@ -163,7 +163,7 @@ export function createFilesController({ Scope: PassedScope }: { Scope?: Type<Dam
                 throw new NotFoundException();
             }
 
-            return this.streamFile(file, res, { range });
+            return this.streamFile(file, res, { range, overrideHeaders: { "cache-control": "max-age=86400, public" } }); // Public cache (1 day)
         }
 
         private isValidHash(hash: string, fileParams: FileParams): boolean {
diff --git a/packages/api/cms-api/src/dam/images/images.controller.ts b/packages/api/cms-api/src/dam/images/images.controller.ts
index 8d35b25e49..96a0fae02e 100644
--- a/packages/api/cms-api/src/dam/images/images.controller.ts
+++ b/packages/api/cms-api/src/dam/images/images.controller.ts
@@ -64,7 +64,7 @@ export class ImagesController {
         }
 
         return this.getCroppedImage(file, params, accept, res, {
-            "cache-control": "private",
+            "cache-control": "max-age=31536000, private", // Local caches only (1 year)
         });
     }
 
@@ -90,7 +90,7 @@ export class ImagesController {
         }
 
         return this.getCroppedImage(file, params, accept, res, {
-            "cache-control": "private",
+            "cache-control": "max-age=31536000, private", // Local caches only (1 year)
         });
     }
 
@@ -107,7 +107,9 @@ export class ImagesController {
             throw new NotFoundException();
         }
 
-        return this.getCroppedImage(file, params, accept, res);
+        return this.getCroppedImage(file, params, accept, res, {
+            "cache-control": "max-age=86400, public", // Public cache (1 day)
+        });
     }
 
     @DisableCometGuards()
@@ -123,7 +125,9 @@ export class ImagesController {
             throw new NotFoundException();
         }
 
-        return this.getCroppedImage(file, params, accept, res);
+        return this.getCroppedImage(file, params, accept, res, {
+            "cache-control": "max-age=86400, public", // Public cache (1 day)
+        });
     }
 
     private isValidHash({ hash, ...imageParams }: HashImageParams): boolean {