Add upgrade script for theme imports #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e834212 to
23499cf
Compare
4 tasks
23499cf to
21bff9b
Compare
johnnyomair
reviewed
Feb 26, 2025
Comment on lines
+52
to
+62
| if (existsSync("admin/package.json")) { | ||
| const packageJson = new PackageJson("admin/package.json"); | ||
| const themeVersion = packageJson.getDependencyVersion("@comet/admin-theme"); | ||
| packageJson.removeDependency("@comet/admin-theme"); | ||
|
|
||
| if (!packageJson.hasDependency("@comet/admin")) { | ||
| packageJson.addDependency("@comet/admin", themeVersion || "^8.0.0"); | ||
| } | ||
|
|
||
| packageJson.save(); | ||
| } |
There was a problem hiding this comment.
This needs to be done in a before-install script, otherwise the update of the Comet packages will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the changes made in vivid-planet/comet#3479
Further information