Remove mikro-orm:drop script
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script doesn't work because MikroORM doesn't know about entities defined in the library.
johnnyomair
commented
Oct 10, 2024
| @@ -18,7 +18,6 @@ | |||
| "lint:generated-files-not-modified": "npm run api-generator && git diff --exit-code HEAD --", | |||
| "lint:tsc": "tsc --project ./tsconfig.lint.json", | |||
| "mikro-orm": "mikro-orm", | |||
There was a problem hiding this comment.
IMO we could remove this script as well. I doubt anyone uses it...
johnnyomair
commented
Oct 10, 2024
| @@ -18,7 +18,6 @@ | |||
| "lint:generated-files-not-modified": "npm run api-generator && git diff --exit-code HEAD --", | |||
| "lint:tsc": "tsc --project ./tsconfig.lint.json", | |||
| "mikro-orm": "mikro-orm", | |||
| "mikro-orm:drop": "mikro-orm schema:drop -r", | |||
| "mikro-orm:migration:generate": "mikro-orm migration:create", | |||
There was a problem hiding this comment.
Also, why do we use the term generate, and not create?
There was a problem hiding this comment.
I guess because typeorm uses generate. I'd remove both mikro-orm scripts.
fraxachun
approved these changes
Oct 11, 2024
nsams
approved these changes
Oct 11, 2024
dkarnutsch
approved these changes
Oct 11, 2024
thomasdax98
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script doesn't work because MikroORM doesn't know about entities defined in the library.