-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: hide columns with constant values #190
Comments
@tpietruszka Thanks for your suggestion! It will be good to be able to hide the columns with same value for all runs, but it will be hard to implement. Omniboard uses server side pagination for faster initial render and to support large number of experiments. Hence, client (frontend) will not be able to determine if a column has constant values. Also, this feature will be hard to maintain since a static column can become a dynamic column and the client should be able to display that column suddenly and also apply the previous settings (show/hide/rearrange/resize of columns). |
I see... I should have read the code more carefully. I mean if I'm browsing 50/100/200 rows, usually the top ones according to the score, I care most about comparing those. If I need a complete config - I can still get it just clicking on any of runs. I Imagine just setting Does this make sense? I can work on implementation, just wanted to know if it is a pointless endeavor |
@tpietruszka That makes sense. And I think it will be useful to show constants in the top. Please go ahead and work on the implementation and let me know if you have any questions while development. Thanks! |
@vivekratnavel sorry to bother you but I have some problem, and not having much experience in Node-related stuff I'm not sure where the problem is. when I've just cloned omniboard, and ran The problem looks like this:
Do you have any suggestions? Might it be some yarn.lock anomaly? I also tried running |
Hi @tpietruszka , Thanks for taking this initiative! I have installed the following node and yarn versions and it works fine: You can have multiple versions of node installed and switch between them by using Please try and let me know if you are still facing issues. |
I also found this issue while searching for your specific issue - yarnpkg/yarn#7900 |
Thanks for the nvm tip! After following your latest link it seems like it is an issue with NPM. They have an issue, (still open since 3 weeks ago) on their statuspage: https://status.npmjs.org/incidents/lvgmcrfvrvsh , and to quote:
|
@tpietruszka I have fixed all the npm related issues and added support for latest version of Node v12. You can now pull the latest code and use node 12 to develop Omniboard. Please let me know if you have any other issues. |
First of all, thank you for the great tool that Omniboard already is!
A suggestion:
It would be useful to, in the main table, automatically hide columns that have the same value for all the displayed runs, and perhaps add a box with these constants above/below the table.
It is a common pattern I use when analyzing results in a notebook, and it really helps with the readability of resulting tables. It lets the user compare things that actually differ, without the unnecessary clutter.
I see it as an optional feature (enabled in settings), ran after all the row filtering and adding custom columns has been applied.
My initial instinct, after browsing the code very briefly, would be to add it purely in the client, in the RunsTable class.
What do you think about the feature, and how would you approach the implementation?
The text was updated successfully, but these errors were encountered: