Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niiiiiice :) #2

Open
vitass opened this issue Apr 12, 2022 · 1 comment
Open

Niiiiiice :) #2

vitass opened this issue Apr 12, 2022 · 1 comment
Assignees

Comments

@vitass
Copy link
Collaborator

vitass commented Apr 12, 2022

Loving the concept and the simplicity of it, the photos, too omg so cool 📸.
Neat idea to have the minimap via canvas. Just a tip there if you want - maybe good to use a single Canvas DOM element and update content inside of it to avoid too much memory overhead if a longer page occurs. ❤️

@vitordino
Copy link
Owner

vitordino commented Apr 17, 2022

that’s indeed a great idea.. i thought on doing it with a fixed position, but certainly by reusing the same canvas would be better

ideally i’m not redrawing that canvas much, only when resizing — i’m using the svg "brush" thing to don’t recalculate on the same canvas, haven’t measured how heavy it is tho.

but indeed when i "finish" the base would be the most important place to shave edges on js performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants