Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete TabletHealth from healthy during deleteTablet #7123

Closed
xhh1989 opened this issue Dec 6, 2020 · 0 comments · Fixed by #7176
Closed

delete TabletHealth from healthy during deleteTablet #7123

xhh1989 opened this issue Dec 6, 2020 · 0 comments · Fixed by #7176

Comments

@xhh1989
Copy link
Contributor

xhh1989 commented Dec 6, 2020

I have a question why not delete TabletHealth from healthy druing deleteTablet.
https://github.com/vitessio/vitess/blob/master/go/vt/discovery/healthcheck.go#L376
for example, an app can read from any replica, we call GetHealthyTabletStats(ks, shard, replica) read from replica, we did some changes in vitess, if GetHealthyTabletStats(ks, shard, replica) returned an empty list, we will call GetHealthyTabletStats(ks, shard, rdonly) instead , but now GetHealthyTabletStats(ks, shard, replica) may return an replica list with unhealthy replicas, that cause an error to app, besides according to the function name, it should not return an unhealthy replica.
It maybe better to delete TabletHealth from healthy during deleteTablet called.

@askdba askdba added the P3 label Dec 6, 2020
@deepthi deepthi changed the title delete TabletHealth from healthy druing deleteTablet delete TabletHealth from healthy during deleteTablet Dec 8, 2020
@deepthi deepthi assigned deepthi and unassigned systay Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants