Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: VTAdmin not usable in local examples #16779

Closed
mattlord opened this issue Sep 13, 2024 · 0 comments · Fixed by #16778
Closed

Bug Report: VTAdmin not usable in local examples #16779

mattlord opened this issue Sep 13, 2024 · 0 comments · Fixed by #16778
Assignees
Labels

Comments

@mattlord
Copy link
Contributor

mattlord commented Sep 13, 2024

Overview of the Issue

When running the local examples VTAdmin (web server) is not running.

Reproduction Steps

git checkout main && make build

cd examples/local

./101_initial_cluster.sh; mysql < ../common/insert_commerce_data.sql

curl localhost:14201

❯ cat ${VTDATAROOT}/tmp/vtadmin-web.out
 INFO  Accepting connections at http://localhost:14201/
 HTTP  9/13/2024 8:26:32 AM 127.0.0.1 GET /

 INFO  Gracefully shutting down. Please wait...
/Users/matt/git/vitess/web/vtadmin/node_modules/serve-handler/src/index.js:47
		const expression = pathToRegExp(normalized, keys);
		                   ^

TypeError: pathToRegExp is not a function
    at sourceMatches (/Users/matt/git/vitess/web/vtadmin/node_modules/serve-handler/src/index.js:47:22)
    at toTarget (/Users/matt/git/vitess/web/vtadmin/node_modules/serve-handler/src/index.js:70:18)
    at applyRewrites (/Users/matt/git/vitess/web/vtadmin/node_modules/serve-handler/src/index.js:105:18)
    at module.exports (/Users/matt/git/vitess/web/vtadmin/node_modules/serve-handler/src/index.js:618:24)
    at run (file:///Users/matt/git/vitess/web/vtadmin/node_modules/serve/build/main.js:181:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Binary Version

❯ vtgate --version
vtgate version Version: 21.0.0-SNAPSHOT (Git revision 155ede0dea490f998e5927e5382a3ab583cd36a8 branch 'main') built on Fri Sep 13 09:19:02 EDT 2024 by matt@pslord.local using go1.23.1 darwin/arm64

Operating System and Environment details

N/A

Log Fragments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant