Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad #include #35

Open
Benualdo opened this issue Feb 5, 2025 · 5 comments
Open

Bad #include #35

Benualdo opened this issue Feb 5, 2025 · 5 comments
Labels
clean Clean codebase

Comments

@Benualdo
Copy link
Member

Benualdo commented Feb 5, 2025

Physics.cpp > IREnderer.h > Renderer_consts.h > Device_consts.h

@Benualdo Benualdo added the clean Clean codebase label Feb 5, 2025
@kdridi
Copy link
Contributor

kdridi commented Feb 5, 2025

core\GameObject\GameObject.cpp :
#include "renderer/IGraphicInstance.h"

@kdridi
Copy link
Contributor

kdridi commented Feb 5, 2025

src\physics\IShape.h :
#include "renderer/Importer/CollisionImporterData.h"

@kdridi
Copy link
Contributor

kdridi commented Feb 5, 2025

src\renderer\DebugDraw\DebugDraw.cpp :
#include "engine/IEngine.h"

src\renderer\Picking\PickingManager.cpp :
#include "editor/Editor_Consts.h"

renderer/RenderPass/ImGui/Extensions/FontStyle/ImGuiFontStyleExtension.h :
#include "editor/ImGui/ImGui.h"

src\renderer\RenderPass\ImGui\ImGuiPass.cpp :
#include "engine/IEngine.h"
#include "editor/IEditor.h"
#include "ImGui.hpp"
#include "ImGuiAdapter.hpp"

@kdridi
Copy link
Contributor

kdridi commented Feb 5, 2025

engine\Component\Editor\Snap\SnapComponent.cpp :
#include "editor/Editor_Consts.h"

engine/Resource/Audio/SoundResource.h :
#include "audio/Audio_Consts.h"

engine\Component\Debug\TestComponent\TestComponent.cpp :
#include "editor/Editor_Consts.h"

engine/Resource/Audio/SoundResource.h :
#include "audio/Audio_Consts.h"

engine\Component\Engine\NotifyParent/NotifyParentComponent.hpp :
#include "editor/Editor_Consts.h"

engine\Component\Physics\Object/PhysicsObjectComponent.hpp :
#include "physics/Physics_Consts.h"
#include "engine/EngineOptions.h"

etc...

@kdridi
Copy link
Contributor

kdridi commented Feb 5, 2025

projects\game\src\Precomp.h :
#include "editor/Editor_Consts.h"

projects\game\src\Game.h :
#include "application/IGame.h"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean Clean codebase
Projects
None yet
Development

No branches or pull requests

2 participants