@var for public promoted properties leading to property not found

[iquito]

In version 4.12.0 of Psalm there are increased levels of problems with constructor property promotion - any @var annotations within constructor property promotion for public properties leads to those properties not even existing to Psalm:

https://psalm.dev/r/db3ba03f68

Gives the errors:

ERROR: InvalidDocblock - 9:9 - Param string of A::__construct should be documented as a param or a property, not both

ERROR: UndefinedPropertyAssignment - 15:1 - Instance property A::$string is not defined

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/db3ba03f68

<?php

final class A
{
	public function __construct(
        /**
         * @var string Some documentation for what the values of this string could be
         */
        public string $string,
    ) {
    }
}

$a = new A('dada');
$a->string = 'da';

Psalm output (using commit 9491ea4):

ERROR: InvalidDocblock - 9:9 - Param string of A::__construct should be documented as a param or a property, not both

ERROR: UndefinedPropertyAssignment - 15:1 - Instance property A::$string is not defined

[orklah]

Yeah, this is the same issue as #6857

I'll fix that

[iquito]

Great, thanks!