-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faulty playback of Alternate-Audio Playlists with Primary/Backup, if Primary returns 404 (since hls.js 0.8.3) #1438
Comments
This is pretty curious - if i click on the demo link (#1 in steps to reproduce) the playback starts. But if you reload the demo-page it's getting broken. |
Thanks @netTrekfd for opening this ticket! one note: |
I gave it a try and this commit broke something between 0.8.2 and 0.8.3 (stream controller is stuck in IDLE if first level request fails ...) |
I'm going to look into this. What exactly we had in |
Thanks @NicolasSiver for providing the fix. I can confirm that the first of my sample streams now is playable. Can you please check and reopen? |
@NicolasSiver @mangui Could you please recheck this issue with my teststream (see comment above). I think the switching logic is still broken. Or shall i create a new ticket for it? |
@netTrekfd Hey! I tested and indeed the 404 error doesn't recover well. Would need to look further into this. Feel free to contact me directly. |
@netTrekfd this might fix this issue in a simple way ^ :) check it out. |
Re-opening this as it is not fixed on master yet, see PR #1630 which fixes this partly (but not merged yet). |
Here is an updated description of the issue which is partly solved by above PR Status:
Expected behavior:
Sample-Playlist: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Environment
https://apiproxy.akamaized.net/hlsjs/av/master_prim_faila.m3u8 or
https://apiproxy.akamaized.net/hlsjs/multichannelaudio/master_prim_fail_v1a.m3u8
Steps to reproduce
Expected behavior
hls.js supports fallback to backup-renditions in older versions, but it generally seems to fail on playlists with GROUP-IDs, supporting alternate audio.
More info on Primary/Backup-Playlists:
https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/StreamingMediaGuide/UsingHTTPLiveStreaming/UsingHTTPLiveStreaming.html#//apple_ref/doc/uid/TP40008332-CH102-SW22
More info on Error-Handling for HTTP-Live-Streaming:
https://developer.apple.com/videos/play/wwdc2017/514/
Actual behavior
there is a final "error while loading level playlist" instead of falling back to the backup source.
Console output
The text was updated successfully, but these errors were encountered: