Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in DenseRank code #545

Closed
viceroypenguin opened this issue Nov 6, 2023 · 0 comments · Fixed by #546
Closed

Bug in DenseRank code #545

viceroypenguin opened this issue Nov 6, 2023 · 0 comments · Fixed by #546
Assignees
@viceroypenguin
Labels
bug Something isn't working
Milestone
5.3.0

Comments

@viceroypenguin
Copy link
Owner 

Enumerable.Range(0, 10)
  .Concat(Enumerable.Range(0, 10))
  .Concat(Enumerable.Range(0, 10))
  .DenseRank()

and

Enumerable.Range(0, 10)
  .Concat(Enumerable.Range(0, 10))
  .Concat(Enumerable.Range(0, 10))
  .ToList()
  .DenseRank()

have different behaviors. Specifically, the .ToList() version does not operate as a dense rank. Tests should be updated to use IDisposableEnumerable<> tests (ex: PadTests), and the bug fixed.
@viceroypenguin viceroypenguin added the bug Something isn't working label Nov 6, 2023
@viceroypenguin viceroypenguin added this to the 5.3.0 milestone Nov 6, 2023
@viceroypenguin viceroypenguin self-assigned this Nov 6, 2023
@viceroypenguin viceroypenguin mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viceroypenguin viceroypenguin

Labels
bug Something isn't working
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Fix DenseRank bug viceroypenguin/SuperLinq
1 participant
@viceroypenguin