Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill query should have permission requirements #3864

Closed
cooper-lzy opened this issue Feb 8, 2022 · 1 comment · Fixed by #3896
Closed

kill query should have permission requirements #3864

cooper-lzy opened this issue Feb 8, 2022 · 1 comment · Fixed by #3896
Assignees
@Shylock-Hg @foesa-yang
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.1.0

Comments

@cooper-lzy
Copy link
Contributor

You can run the KILL QUERY command with any permission.

image

image
@Sophie-Xie Sophie-Xie removed their assignment Feb 8, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Feb 8, 2022
@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Feb 8, 2022
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.1.0 Feb 11, 2022
@Shylock-Hg Shylock-Hg self-assigned this Feb 11, 2022
@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Feb 11, 2022 •
edited
Loading

Design it to GOD could kill all quries, others could kill own queries.

@jamieliu1023 jamieliu1023 mentioned this issue Feb 12, 2022
Closed
@Shylock-Hg Shylock-Hg mentioned this issue Feb 15, 2022
Merged
11 tasks
@Sophie-Xie Sophie-Xie moved this from Backlog to Reviewing in Nebula Graph v3.1.0 Feb 22, 2022
Repository owner moved this from Reviewing to Done in Nebula Graph v3.1.0 Feb 28, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Mar 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shylock-Hg Shylock-Hg

@foesa-yang foesa-yang

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.1.0
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Add permission checking for kill queries. Shylock-Hg/nebula
4 participants
@Shylock-Hg @foesa-yang @cooper-lzy @Sophie-Xie