Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing Azure tests #19877

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Fix failing Azure tests #19877

merged 3 commits into from
Dec 8, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 5, 2020

Noticed Azure tests have started failing after #19758 due to the middleware taking longer than the allotted threshold which adds unexpected logs to stderr. This attempts to resolve these test failures by increasing the allotted time for the middleware when running on Azure.

x-ref: https://dev.azure.com/nextjs/next.js/_build/results?buildId=22617&view=logs&jobId=5ee44de4-e310-59d9-0ba5-4a271a649fb0&j=5ee44de4-e310-59d9-0ba5-4a271a649fb0&t=af3fb693-3771-5a1a-ec97-2ba4cc77f25c
x-ref: https://dev.azure.com/nextjs/next.js/_build/results?buildId=22619&view=logs&jobId=5ee44de4-e310-59d9-0ba5-4a271a649fb0&j=5ee44de4-e310-59d9-0ba5-4a271a649fb0&t=af3fb693-3771-5a1a-ec97-2ba4cc77f25c

@ijjk ijjk added the type: next label Dec 5, 2020
@vercel vercel bot temporarily deployed to Preview December 5, 2020 20:50 Inactive
@ijjk
Copy link
Member Author

ijjk commented Dec 5, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 8.9s 9.1s ⚠️ +255ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.204 2.19 -0.01
/ avg req/sec 1134.1 1141.62 +7.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.14 1.167 ⚠️ +0.03
/error-in-render avg req/sec 2192.34 2142.07 ⚠️ -50.27
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/azure-tests Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 10.8s 10.7s -35ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_error.js 1 MB 1 MB ⚠️ +73 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +73 B
link.js 1.06 MB 1.06 MB ⚠️ +73 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +73 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +73 B
Overall change 5.16 MB 5.16 MB ⚠️ +365 B
Commit: 23c52b3

@ijjk ijjk marked this pull request as ready for review December 6, 2020 03:11
@vercel vercel bot temporarily deployed to Preview December 7, 2020 20:29 Inactive
@ijjk
Copy link
Member Author

ijjk commented Dec 7, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 11.4s 11.4s ⚠️ +7ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/azure-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.915 2.773 -0.14
/ avg req/sec 857.72 901.59 +43.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.703 1.694 -0.01
/error-in-render avg req/sec 1468.07 1476.2 +8.13
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/azure-tests Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 13.2s 13.3s ⚠️ +86ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_error.js 1 MB 1 MB ⚠️ +73 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +73 B
link.js 1.06 MB 1.06 MB ⚠️ +73 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +73 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +73 B
Overall change 5.16 MB 5.16 MB ⚠️ +365 B
Commit: 3ddca62

@vercel vercel bot temporarily deployed to Preview December 8, 2020 03:37 Inactive
@ijjk
Copy link
Member Author

ijjk commented Dec 8, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 11.3s 11.8s ⚠️ +466ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/azure-tests Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.866 2.821 -0.04
/ avg req/sec 872.37 886.15 +13.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.74 1.739 0
/error-in-render avg req/sec 1437.12 1437.48 +0.36
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/azure-tests Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
buildDuration 13.8s 13.7s -77ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +266 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/azure-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..fd29.js gzip 303 B 303 B ✓
withRouter-b..76ae.js gzip 302 B 302 B ✓
Overall change 8.31 kB 8.31 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/azure-tests Change
_error.js 1 MB 1 MB ⚠️ +73 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +73 B
link.js 1.06 MB 1.06 MB ⚠️ +73 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +73 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +73 B
Overall change 5.16 MB 5.16 MB ⚠️ +365 B
Commit: 19ace43

@kodiakhq kodiakhq bot merged commit cf46655 into vercel:canary Dec 8, 2020
@ijjk ijjk deleted the fix/azure-tests branch December 8, 2020 16:25
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens