Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback: true serves app shell to crawlers #23647

Closed
leo opened this issue Apr 2, 2021 · 2 comments
Closed

fallback: true serves app shell to crawlers #23647

leo opened this issue Apr 2, 2021 · 2 comments
Labels
bug Issue was opened via the bug report template.

Comments

@leo
Copy link
Contributor

leo commented Apr 2, 2021

What version of Next.js are you using?

10.1.3

What version of Node.js are you using?

14.16.0

What browser are you using?

All browsers

What operating system are you using?

All operating systems

How are you deploying your application?

Vercel, next start and next dev

Describe the Bug

If the fallback property within getStaticPaths is set to true, an incoming request for a parameter that doesn't yet match a generated path will cause the app shell to be delivered and the contents of the page to be fetched on the client side afterwards. Subsequent requests will then receive the generated page instead of the app shell.

This behavior is expected and matches the documentation. However, in the case that a crawler (like Google) sends such a request and there isn't yet a generated version of the path available, it will also be served the app shell, which makes it impossible for certain crawlers to parse the content of the page, because the content is only available on the client side, which doesn't even exist in the case of many crawlers.

Expected Behavior

Whenever a crawler (like Google) visits a page that has fallback set to true, the response should be blocked on generating the page — as if fallback was temporarily set to blocking.

To Reproduce

The description above already outlines how to reproduce the bug.

@leo leo added the bug Issue was opened via the bug report template. label Apr 2, 2021
@ijjk
Copy link
Member

ijjk commented Sep 20, 2021

Closing as this is now resolved by #29121

@ijjk ijjk closed this as completed Sep 20, 2021
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

No branches or pull requests

3 participants