Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lines are created for progressive updates rather than replacing the old ones #1732

Closed
2 tasks done
ingro opened this issue Apr 7, 2017 · 14 comments
Closed
2 tasks done
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself

Comments

@ingro
Copy link

ingro commented Apr 7, 2017

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 Pro build 1703 (creators update)
  • Hyper.app version: 1.3.1
  • Link of a Gist with the contents of your .hyper.js: default
  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): n/a
  • The issue is reproducible in vanilla Hyper.app: is vanilla

Issue

After updating Windows 10 to the last version (creators update) I wanted to try again hyper.app with the improved bash for window. Unfortunately it seems like progressive updates are broken, new lines are constantly created instead of replacing the old ones and even the cursor is far off its position. Since I wasn't using hyper.app from some times I first disabled all the plugins and the created a fresh .hyper.js config file, but nothing changed. I attached a screenshot to better show the problem.

hyperlines

@jcolesio
Copy link

I'm seeing the same issue after the creators update.

@albinekb albinekb added 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Apr 14, 2017
@siziyman
Copy link

After trying to work around the same issue I've discovered that line breaks "break" at exactly 160 terminal chars width Hyper window regardless of font size or anything else, at least at my own PC.
I can provide screenshots or record a screencast to show apparent difference in behaviour at 159 and 160 characters (making window larger doesn't help, apparently).

@Jofagi
Copy link

Jofagi commented Apr 23, 2017

I observed the same behavior as @siziyman.
I'm running on Win10 with Creator's Update. The problem doesn't show up on another Win10 PC which does not yet have the Creator's Update.

@MartyGentillon
Copy link
Contributor

What is your $TERM variable set to?

@MartyGentillon
Copy link
Contributor

Well, it's doing this with yarn and powershell.

@MartyGentillon
Copy link
Contributor

Also, this seems to result in the offset console bug as well. I have to suspect that it is an issue in the underlying hterm library.

@MartyGentillon
Copy link
Contributor

Interestingly enough, this is only happening with the progress bar. It does not happen with the spinner.

Given that this is also triggering the console offset bug, I suspect that it is the combination of some strange width character and clear line that causes this.

@jcolesio
Copy link

jcolesio commented May 5, 2017

has there been any progress on this issue?

@MartyGentillon
Copy link
Contributor

I suspect that this is going to be fixed when we finish replacing the underlying terminal library.

@gluons
Copy link

gluons commented May 12, 2017

Also happens on PowerShell with Creators Update. It maybe Yarn issue? 😅

default

@gluons
Copy link

gluons commented May 12, 2017

Related issue: yarnpkg/yarn#2530

@ppot ppot added 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself and removed 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper labels May 12, 2017
@m4r1vs
Copy link

m4r1vs commented Aug 6, 2017

has anyone an idea when this will be fixed?

@gluons
Copy link

gluons commented Sep 15, 2017

Fixed by yarnpkg/yarn#4317. 🎉

We can wait for Yarn newer version.
Or test by grabbing the artifact from https://ci.appveyor.com/project/kittens/yarn/build/3769/job/3owvdyefkpofp10x/artifacts

default

@chabou
Copy link
Contributor

chabou commented Sep 15, 2017

@gluons Thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself
Projects
None yet
Development

No branches or pull requests

10 participants