Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper should fallback to default config when not specified in ~/.hyper.js #1588

Closed
sindresorhus opened this issue Feb 27, 2017 · 4 comments
Closed
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@sindresorhus
Copy link
Contributor

My ~./hyper.js is:

'use strict';
module.exports = {
	config: {
		fontSize: 16,
		fontFamily: 'Menlo'
	},
	plugins: [
		'hyper-snazzy'
	]
};

Since I deleted default config like the css option, that property is now undefined in decorateConfig for plugins. Hyper should provide default values in the core for all config properties.

For now, I'll have to specify an empty css: '' option so plugins/themes using config.css doesn't break.

@matheuss matheuss added help wanted Contributions wanted towards the issue 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Feb 27, 2017
@albinekb albinekb added the good first issue Issue is good for Hyper newcomers label Mar 7, 2017
@ppot
Copy link
Contributor

ppot commented Mar 11, 2017

Could be integrated into #1509

@Gaserd
Copy link

Gaserd commented Mar 30, 2017

Hi, is anyone is working on this bug ?

@okonek
Copy link
Contributor

okonek commented Aug 30, 2017

I created PR

@chabou
Copy link
Contributor

chabou commented Sep 6, 2017

Fixed by #2126
Thank you so much @okonek ❤️

@chabou chabou closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests

7 participants