Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Ruby Versions? #28

Closed
BrianBorge opened this issue Mar 5, 2020 · 5 comments
Closed

Supported Ruby Versions? #28

BrianBorge opened this issue Mar 5, 2020 · 5 comments

Comments

@BrianBorge
Copy link
Contributor

BrianBorge commented Mar 5, 2020

I noticed there is no information about supported ruby versions. What are they and how should the repo be updated to include this information?

Options for updating the repo:

  1. Update the README to include ruby version requirements
  2. Adding a .ruby-version file for ruby version managers to pick up on
  3. Update the ruby gem metadata to stamp out required ruby version(s) [1]

Thoughts? I like options 1 and 3.

1: https://guides.rubygems.org/specification-reference/#required_ruby_version

@aharpervc
Copy link
Contributor

I think it's reasonable to add a .ruby-version file for development. My expectation is that supported ruby versions would be driven primarily by dependencies, however I can't think of any reason to avoid spec.required_ruby_version = '~> 2.5' either.

@aharpervc
Copy link
Contributor

We should also update the CircleCI config to test against all the versions of Ruby we decide to support.

@BrianBorge
Copy link
Contributor Author

That's a good idea. Can I assign these two items to myself?

@aharpervc
Copy link
Contributor

That's a good idea. Can I assign these two items to myself?

Go for it

@aharpervc
Copy link
Contributor

Solved by 95a03bb and #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants