-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with jsonapi-resources 0.10 #64
Comments
Ok JR 0.10 has been released now. It seems that the major changes done are things concerning jsonapi-authorization, so it will take quite an effort to get us compatible with it. https://jsonapi-resources.com/v0.10/guide/whats_new.html We should update this gem to be compatible with JR 0.10 and release a new major version to support only that version. People on older versions could use older versions of jsonapi-authorization. Any help is appreciated. I don't have time any time soon to look into this and neither is this a priority on our team any time soon. |
@valscion do you have any sort of tasklist of things that need to be touched ? |
Not really, sorry. One thing I'd really like to see here would be a new approach to tests where we would assert on user visible functionality — so going from a full request to an expected authorization error without relying on any stubbing. Some of the current tests have gotten so complex due to the authorization stubbing going on that I have a lack of trust on any big changes done to the existing tests. These new types of tests could first start small and test only a subset of the authorization logic. I'd like them to be in a totally different directory than the existing RSpec tests, and as self-contained as possible. Meaning that the resources, controllers and policies needed for the tests would all be in one file, even if it would make for a longer file. This type of tests could be done with minitest instead of RSpec, too. |
Hello, any progress with supporting 0.10? 4 months since issue opening. |
Does not seem like it. Feel free to offer help if you need JR 0.10 support. |
I'm sorry the JR 0.10 changes have broken this project. I'm interested in helping to get this resolved, though I have a few concerns about efficiency in addition to the compatibility issues with the new way JR v0.10 works. I have spent very little time looking at it so far, but I think most of the issues should be fairly easily solvable. |
Thank you for offering to help, @lgebhardt The way we've previously tied into JR has been like so (copied from current readme):
|
We never managed to fix the compatibility with |
Seems like we will have to do some work in the future to be compatible with upcoming JR version, 0.10, where resources being closely coupled to ActiveRecord is being worked on.
@hidde-jan in #48 (comment)
EDIT:
The text was updated successfully, but these errors were encountered: