Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Make Customers ChannelAware #454

Merged
merged 6 commits into from
Sep 14, 2020

Conversation

hendrik-advantitge
Copy link
Contributor

No description provided.

@hendrik-advantitge
Copy link
Contributor Author

If a customer has a user account and uses the 'login' mutation on a channel that is not yet assigned to his customer entity, the channel will not yet be assigned to it. This will only happen on the next query/mutation.
This is a side effect of assigning customers to channels before the actual request is handled: before actually logging in there is no customer yet to assign to a channel.

@michaelbromley michaelbromley linked an issue Sep 11, 2020 that may be closed by this pull request
Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please see the review comments 👍

@michaelbromley michaelbromley merged commit 0f73473 into vendure-ecommerce:next Sep 14, 2020
@michaelbromley
Copy link
Member

Thank you so much for the work you put in on this! 🎉

@thomas-advantitge thomas-advantitge deleted the feature/#70vheh branch September 17, 2020 14:07
@loveyandex
Copy link

@michaelbromley how can we define a vendor for a channel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Customers ChannelAware
3 participants