Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add enabled flag to CreateProductVariant input #3377

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dlhck
Copy link
Collaborator

@dlhck dlhck commented Feb 20, 2025

Description

Adds the enabled flag to the CreateProductVariantInput type, to pass the flag already add variant creation. The default value for enabled is already true but this allows to manually control that.

Resolves #3339

Breaking changes

none

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@dlhck dlhck requested a review from michaelbromley February 20, 2025 16:24
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 20, 2025 4:24pm

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@michaelbromley michaelbromley merged commit f5a0f99 into master Feb 21, 2025
32 of 33 checks passed
@michaelbromley michaelbromley deleted the admin-api-variant-enabled-flag branch February 21, 2025 06:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateProductVariantInput is missing enabled field
2 participants