Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.0.0] Admin UI - roles - enabled vs. disabled rights readability #2224

Closed
mpacary opened this issue Jun 12, 2023 · 1 comment
Closed

[v2.0.0] Admin UI - roles - enabled vs. disabled rights readability #2224

mpacary opened this issue Jun 12, 2023 · 1 comment
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@mpacary
Copy link
Contributor

mpacary commented Jun 12, 2023

Issue description
The current colors for enabled & disabled rights icons are very close, making them difficult to be told apart.

To Reproduce
Steps to reproduce the behavior:

  1. Login to admin UI as a superadmin
  2. Go to section Settings > Roles
  3. Create or modify a role

Version
Vendure v2.0.0

In the example below, all CRUD rights are enabled on Catalog, and only Read on Channel. Others are disabled (AFAICS 😅).
image

This is rather a UX issue than a bug ; feel free to modify the labels of course.

@mpacary mpacary added the type: bug 🐛 Something isn't working label Jun 12, 2023
@mpacary mpacary changed the title Admin UI - roles - enabled vs. disabled rights readability [v2.0.0] Admin UI - roles - enabled vs. disabled rights readability Jun 12, 2023
@michaelbromley
Copy link
Member

Thanks for the report - and good point!

In the next patch this will be improved to look like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants