From 73a78dbbf54c324dcfe6af7b173aba3f08d94a04 Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Wed, 6 Sep 2023 13:36:40 +0200 Subject: [PATCH] fix(admin-ui): Give all data table columns immutable ids Previously the ID was based on the heading, which changed when updating the current display language. --- .../collection-contents.component.html | 10 +-- .../collection-list.component.html | 18 ++--- .../facet-list/facet-list.component.html | 14 ++-- .../move-collections-dialog.component.html | 8 +-- .../product-list/product-list.component.html | 69 +++---------------- .../product-options-editor.component.html | 12 ++-- .../product-variant-list.component.html | 20 +++--- .../product-variants-editor.component.html | 18 ++--- .../stock-location-list.component.html | 10 +-- .../data-table-column.component.ts | 5 +- ...ata-table-custom-field-column.component.ts | 5 +- .../customer-detail.component.html | 16 ++--- .../customer-group-list.component.html | 10 +-- .../customer-group-member-list.component.html | 12 ++-- .../customer-list.component.html | 12 ++-- .../latest-orders-widget.component.html | 10 +-- .../promotion-list.component.html | 20 +++--- .../order-history-entry-host.component.ts | 2 +- .../order-list/order-list.component.html | 20 +++--- .../order-table/order-table.component.html | 12 ++-- .../administrator-list.component.html | 12 ++-- .../channel-list/channel-list.component.html | 10 +-- .../country-list/country-list.component.html | 12 ++-- .../payment-method-list.component.html | 12 ++-- .../role-list/role-list.component.html | 14 ++-- .../seller-list/seller-list.component.html | 8 +-- .../shipping-method-list.component.html | 14 ++-- .../tax-category-list.component.html | 10 +-- .../tax-rate-list.component.html | 18 ++--- .../zone-list/zone-list.component.html | 10 +-- .../zone-member-list.component.html | 12 ++-- .../job-list/job-list.component.html | 14 ++-- 32 files changed, 196 insertions(+), 253 deletions(-) diff --git a/packages/admin-ui/src/lib/catalog/src/components/collection-contents/collection-contents.component.html b/packages/admin-ui/src/lib/catalog/src/components/collection-contents/collection-contents.component.html index 70e152dd66..7b428d6eb8 100644 --- a/packages/admin-ui/src/lib/catalog/src/components/collection-contents/collection-contents.component.html +++ b/packages/admin-ui/src/lib/catalog/src/components/collection-contents/collection-contents.component.html @@ -19,22 +19,22 @@ [searchTermControl]="filterTermControl" [searchTermPlaceholder]="'catalog.filter-by-name' | translate" /> - + {{ variant.id }} - + {{ variant.createdAt | localeDate : 'short' }} - + {{ variant.updatedAt | localeDate : 'short' }} - + {{ variant.name }} - + {{ variant.sku }} diff --git a/packages/admin-ui/src/lib/catalog/src/components/collection-list/collection-list.component.html b/packages/admin-ui/src/lib/catalog/src/components/collection-list/collection-list.component.html index ee5ad91b10..1900c0dec4 100644 --- a/packages/admin-ui/src/lib/catalog/src/components/collection-list/collection-list.component.html +++ b/packages/admin-ui/src/lib/catalog/src/components/collection-list/collection-list.component.html @@ -45,13 +45,13 @@ [searchTermControl]="searchTermControl" [searchTermPlaceholder]="'common.search-by-name' | translate" > - + {{ collection.id }} @@ -60,7 +60,7 @@ @@ -69,7 +69,7 @@ @@ -78,7 +78,7 @@ @@ -104,7 +104,7 @@ - + - + {{ collection.slug }} - + {{ 'common.private' | translate @@ -133,7 +133,7 @@ }} - + - + {{ facet.id }} @@ -55,7 +55,7 @@ @@ -63,7 +63,7 @@ {{ facet.updatedAt | localeDate : 'short' }} - + {{ facet.name }} @@ -71,12 +71,12 @@ - + {{ facet.code }} - + {{ 'common.private' | translate @@ -86,7 +86,7 @@ }} - +
- + {{ collection.id }} - +
- + - + {{ collection.slug }} diff --git a/packages/admin-ui/src/lib/catalog/src/components/product-list/product-list.component.html b/packages/admin-ui/src/lib/catalog/src/components/product-list/product-list.component.html index 423fe78041..7edd977fe8 100644 --- a/packages/admin-ui/src/lib/catalog/src/components/product-list/product-list.component.html +++ b/packages/admin-ui/src/lib/catalog/src/components/product-list/product-list.component.html @@ -47,70 +47,17 @@ [hostComponent]="this" [selectionManager]="selectionManager" > - - + {{ product.id }} @@ -119,7 +66,7 @@