From 58d54808566a117e26ef34e63b9001743864ca94 Mon Sep 17 00:00:00 2001 From: cdiban <7472030+cdiban@users.noreply.github.com> Date: Mon, 21 Aug 2023 05:12:02 -0400 Subject: [PATCH 1/3] chore(core): Export missing symbols (Calculated & Seller) --- packages/core/src/common/index.ts | 1 + packages/core/src/entity/index.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/core/src/common/index.ts b/packages/core/src/common/index.ts index e3167fac56..885eeae0a0 100644 --- a/packages/core/src/common/index.ts +++ b/packages/core/src/common/index.ts @@ -1,6 +1,7 @@ export * from './finite-state-machine/finite-state-machine'; export * from './finite-state-machine/types'; export * from './async-queue'; +export * from './calculated-decorator'; export * from './error/errors'; export * from './error/error-result'; export * from './error/generated-graphql-admin-errors'; diff --git a/packages/core/src/entity/index.ts b/packages/core/src/entity/index.ts index b16e7bf55e..4ffb8e51cd 100644 --- a/packages/core/src/entity/index.ts +++ b/packages/core/src/entity/index.ts @@ -42,6 +42,7 @@ export * from './product/product.entity'; export * from './promotion/promotion.entity'; export * from './refund/refund.entity'; export * from './role/role.entity'; +export * from './seller/seller.entity'; export * from './session/anonymous-session.entity'; export * from './session/authenticated-session.entity'; export * from './session/session.entity'; From 78be541eaae93646c7a94b4e1514648a3581d2c9 Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Mon, 21 Aug 2023 13:17:14 +0200 Subject: [PATCH 2/3] docs(core): Add TTL to example Redis session cache strategy --- .../core/src/config/session-cache/session-cache-strategy.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/core/src/config/session-cache/session-cache-strategy.ts b/packages/core/src/config/session-cache/session-cache-strategy.ts index bd0f0dfe46..5cc4edf0b5 100644 --- a/packages/core/src/config/session-cache/session-cache-strategy.ts +++ b/packages/core/src/config/session-cache/session-cache-strategy.ts @@ -69,6 +69,7 @@ export type CachedSession = { * } * const loggerCtx = 'RedisSessionCacheStrategy'; * const DEFAULT_NAMESPACE = 'vendure-session-cache'; + * const DEFAULT_TTL = 86400; * * export class RedisSessionCacheStrategy implements SessionCacheStrategy { * private client: Redis; @@ -100,7 +101,7 @@ export type CachedSession = { * * async set(session: CachedSession) { * try { - * await this.client.set(this.namespace(session.token), JSON.stringify(session)); + * await this.client.set(this.namespace(session.token), JSON.stringify(session), 'EX', DEFAULT_TTL); * } catch (e: any) { * Logger.error(`Could not set cached session: ${e.message}`, loggerCtx); * } From 738fe68558dab0abdf2115a96e8d83bc78ab9f0d Mon Sep 17 00:00:00 2001 From: Michael Bromley Date: Tue, 22 Aug 2023 09:09:06 +0200 Subject: [PATCH 3/3] docs: Fix ui extension detail view examples --- .../extending-the-admin-ui/creating-detail-views/index.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/content/plugins/extending-the-admin-ui/creating-detail-views/index.md b/docs/content/plugins/extending-the-admin-ui/creating-detail-views/index.md index 3ba1b266b3..4cae394631 100644 --- a/docs/content/plugins/extending-the-admin-ui/creating-detail-views/index.md +++ b/docs/content/plugins/extending-the-admin-ui/creating-detail-views/index.md @@ -18,7 +18,7 @@ Let's say you have a plugin which adds a new entity to the database called `Prod The detail component itself is an Angular component which extends the [BaseDetailComponent]({{< relref "base-detail-component" >}}) or [TypedBaseDetailComponent]({{< relref "typed-base-detail-component" >}}) class. ```TypeScript -import { ChangeDetectionStrategy, Component } from '@angular/core'; +import { ChangeDetectionStrategy, Component, OnInit, OnDestroy } from '@angular/core'; import { FormBuilder } from '@angular/forms'; import { TypedBaseDetailComponent, LanguageCode } from '@vendure/admin-ui/core'; import { gql } from 'apollo-angular'; @@ -47,7 +47,7 @@ export const GET_REVIEW_DETAIL = gql` styleUrls: ['./review-detail.component.scss'], changeDetection: ChangeDetectionStrategy.OnPush, }) -export class ReviewDetailComponent extends TypedBaseDetailComponent implements OnInit, OnDestroy { +export class ReviewDetailComponent extends TypedBaseDetailComponent implements OnInit, OnDestroy { detailForm = this.formBuilder.group({ title: [''], rating: [1], @@ -207,7 +207,7 @@ import { GetReviewDocument, GetReviewDetailQuery } from './generated-types'; const review$ = inject(DataService) .query(GetReviewDocument, { id: route.paramMap.get('id') }) .mapStream(data => data.review); - return of({ detail: { entity: review$ } }); + return of({ entity: review$ }); }, }, data: { @@ -220,7 +220,7 @@ import { GetReviewDocument, GetReviewDetailQuery } from './generated-types'; link: ['/extensions', 'reviews'], }, { - label: `${entity.title}`, + label: `${entity?.title ?? 'New Review'}`, link: [], }, ]),