Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【確認待ち】ツールバーの標準化 #604

Closed
kurudrive opened this issue Jul 14, 2021 · 2 comments · Fixed by #656
Closed

【確認待ち】ツールバーの標準化 #604

kurudrive opened this issue Jul 14, 2021 · 2 comments · Fixed by #656
Assignees
Milestone

Comments

@kurudrive
Copy link
Member

これもう確認・対応済み?

WordPress/gutenberg#31952

@shimotmk
Copy link
Contributor

shimotmk commented Jul 16, 2021

こちら確認したのですが

vk-blocksがツールバーに追加している箇所(BlockControls)は

  • slider
  • select-post-list-item
  • slider-item
  • responsive-br

の4箇所ありました
responsive-br以外は設定可能な要素が1つのみでgroupを分ける意味がないと思うのでresponsive-brのみblockグループに追加します

■現状
br

■blockグループに追加
new-br


※追記
headingブロックが抜けていました
のHeadingLevel,Alignmentもコア同様blockグループに追加します

heading

@shimotmk shimotmk linked a pull request Aug 19, 2021 that will close this issue
@shimotmk shimotmk changed the title ツールバーの標準化 【確認待ち】ツールバーの標準化 Aug 19, 2021
@mthaichi
Copy link
Contributor

@kurudrive @shimotmk レビューしてマージまで実施しました。

@miminari miminari removed their assignment Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants