Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support window in the transform array #2488

Closed
kanitw opened this issue Jun 12, 2017 · 8 comments
Closed

Support window in the transform array #2488

kanitw opened this issue Jun 12, 2017 · 8 comments

Comments

@kanitw
Copy link
Member

kanitw commented Jun 12, 2017

Given the new joinaggregate transform, we should also support this in the transform array.

One possible syntax is to have a join: boolean flag in the SummarizeTransform.

@kanitw kanitw assigned AkshatSh and unassigned yhoonkim Jun 13, 2017
@kanitw kanitw modified the milestones: 2.x.x - Dataflow Optimization, 2.0.0-rc Moderately Important Patches Jun 14, 2017
@kanitw
Copy link
Member Author

kanitw commented Jun 14, 2017

Since @domoritz agree with the join: boolean flag, @AkshatSh you can directly modify AggregateNode and the type definition for SummarizeTransform.

  • I also notice that SummarizeTransform doesn't support cross and drop in Vega's aggregate transform yet, so probably worth adding them too.
    • Note that cross and drop are in aggregate but not in joinaggregate so we will probably have to make some minor type adjustment.

@kanitw kanitw mentioned this issue Jun 27, 2017
10 tasks
@kanitw
Copy link
Member Author

kanitw commented Jul 19, 2017

  • Right now AggregateNode always output type: 'aggregate', but with join: true -- we wanna do joinaggregate.

@kanitw
Copy link
Member Author

kanitw commented Jul 28, 2017

@AkshatSh Let's not add the join flag for now as Jeff is working on a new window transform and will deprecate joinaggregate. That said, supporting cross and drop in aggregate could still be useful :)

@kanitw kanitw changed the title Support joinaggregate in the transform array Support window in the transform array Aug 22, 2017
@kanitw
Copy link
Member Author

kanitw commented Aug 22, 2017

Note that now a window transform has landed. You may want to add a window transform to VL. :)

@kanitw
Copy link
Member Author

kanitw commented Aug 23, 2017

I think window transform syntax should be pretty similar to Vega, but should not have type (type: window) just like our summarize transform does not have type: 'aggregate'.

Please propose a syntax and we can discuss :)

@kanitw
Copy link
Member Author

kanitw commented Dec 1, 2017

Good cases to demonstrate in examples:

  • Percent of total
  • Different from total/mean
  • Percent difference from total/mean

@kanitw kanitw mentioned this issue Mar 3, 2018
3 tasks
@kanitw kanitw modified the milestones: 2.x.x - Dataflow Optimization, 2.x Data & Transforms Patches Mar 4, 2018
@kanitw kanitw mentioned this issue Mar 15, 2018
@kanitw
Copy link
Member Author

kanitw commented Mar 15, 2018

Another example:

@kanitw
Copy link
Member Author

kanitw commented Mar 18, 2018

Will be fixed in #3199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants