From a45b023d60f770a85fdfd6109a90ad1f1d89a268 Mon Sep 17 00:00:00 2001 From: Dominik Moritz Date: Thu, 7 Oct 2021 23:10:40 -0400 Subject: [PATCH] perf: add COUNTING_OPS_INDEX for O(1) lookup (#7744) --- src/aggregate.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/aggregate.ts b/src/aggregate.ts index 1e0c5f8502..cbd16a2d85 100644 --- a/src/aggregate.ts +++ b/src/aggregate.ts @@ -62,9 +62,10 @@ export function isAggregateOp(a: string | ArgminDef | ArgmaxDef): a is Aggregate } export const COUNTING_OPS: NonArgAggregateOp[] = ['count', 'valid', 'missing', 'distinct']; +export const COUNTING_OPS_INDEX = toSet(COUNTING_OPS); export function isCountingAggregateOp(aggregate?: string | Aggregate): boolean { - return isString(aggregate) && contains(COUNTING_OPS, aggregate); + return isString(aggregate) && COUNTING_OPS_INDEX[aggregate]; } export function isMinMaxOp(aggregate?: Aggregate | string): boolean {