Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Typescript Code #9

Open
kanitw opened this issue May 13, 2019 · 7 comments
Open

Output Typescript Code #9

kanitw opened this issue May 13, 2019 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kanitw
Copy link
Member

kanitw commented May 13, 2019

The code for generating the API could still be Javascript, since it only affects us.

However, a lot of people may want to use the output JS API in Typescript projects (which offer superior autocompletion than vanilla JS). Thus, it might be worth making sure that our output code is in TS.

cc: @domoritz

@RandomFractals
Copy link

RandomFractals commented May 13, 2019

yeah, I'd be curious to see TS setup for this lib api too, not just for JS webapps vega viz gen. I prefer to code in TS too!

What's required to make this lib work in & provide proper TS api? Think ahead! cc @domoritz :)

@RandomFractals
Copy link

@kanitw @jheer & @domoritz do you guys still plan to work on the companion https://github.com/vega/vega-lite-to-api repo?

I think it would be great to be able to have a library that generates this vega-lite api code from Vega specs.

I'd love to add that feature to the Vega Viewer 📈 when you are ready for it ...

https://github.com/RandomFractals/vscode-vega-viewer

@kanitw
Copy link
Member Author

kanitw commented Aug 19, 2019

@RandomFractals we will get back to it that some points, but currently doesn't have time to finish it.

@RandomFractals
Copy link

:( ok

@RandomFractals
Copy link

any ETA on this? if you don't think you'll get to it this year, I'd rather close that issue in my repo.

@domoritz
Copy link
Member

We’re more than happy to accept a PR for this feature. I don’t think we have a pressing need for this from our side before the end of the year.

@RandomFractals
Copy link

I'd have to play a bit with this api library to see what needs to be done for the TS code gen. I doubt I'll get to it this year also, but let's keep this open. I think it would be a great feature to have eventually.

@domoritz domoritz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants