Spec version warnings

[ankane]

Hi, when running the HTML from the Vega-Lite tutorial, vega-embed shows two warnings about the spec version.

The input spec uses Vega-Lite v5, but the current version of Vega-Lite is v5.1.1. vega-embed@6.18.2:21:8121
The compiled spec uses Vega v5, but current version is v5.20.2. vega-embed@6.18.2:21:8553

It shows the same warnings with the latest version of vega-embed (6.19.1). Since everything is v5, it seems like there probably shouldn't be any warnings.

[ankane]

There are also source map warnings for each of the libraries:

DevTools failed to load source map: Could not load content for https://cdn.jsdelivr.net/npm/vega-embed.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load source map: Could not load content for https://cdn.jsdelivr.net/npm/vega-lite.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load source map: Could not load content for https://cdn.jsdelivr.net/npm/vega.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

which can be fixed by using the full path:

<script src="https://cdn.jsdelivr.net/npm/vega@5.20.2/build/vega.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-lite@5.1.1/build/vega-lite.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/vega-embed@6.18.2/build/vega-embed.min.js"></script>

[p-himik]

Just want to add that the warnings are there even if the versions are exactly the same:

vega-embed.js:5639 The input spec uses Vega v5.21.0, but the current version of Vega is v5.21.0.

[domoritz]

Hmm, we get a crash in semver "TypeError: Right-hand side of 'instanceof' is not an object at new Range$a (http://localhost:3000/build/vega-embed.js:2712:19) at Object.satisfies$3 [as satisfies] (http://localhost:3000/build/vega-embed.js:3294:17) at guessMode (http://localhost:3000/build/vega-embed.js:5667:21) at _embed (http://localhost:3000/build/vega-embed.js:5802:20) at embed (http://localhost:3000/build/vega-embed.js:5736:20) at async run (http://localhost:3000/test-vl.html:55:24)"

[domoritz]

This seems to be a bug in the bundler and not Vega-Embed. See npm/node-semver#381

[github-actions]

🚀 Issue was released in v6.20.1 🚀

[ankane]

Thanks @domoritz, that fixed it!