Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIPS Compliance #3292

Closed
ccravens opened this issue Dec 21, 2023 · 3 comments
Closed

FIPS Compliance #3292

ccravens opened this issue Dec 21, 2023 · 3 comments

Comments

@ccravens
Copy link
Contributor

ccravens commented Dec 21, 2023

Hello!

I'd like to run altair in a FIPS-compiant environment, however the use of md5 causes the library to fail:

image

I submitted the following PR in the hopes that this could start to work towards a FIPS compliant library, thanks!

#3291

@mattijn
Copy link
Contributor

mattijn commented Dec 21, 2023

Very supportive to try to make Altair available in more restrictive environments.

Could you tell a bit more about this FIPS-compliant environment?

How do we know we adhere to their principles?

@ccravens
Copy link
Contributor Author

Hello @mattijn absolutely! FIPS is a US Federal standard for encryption (https://en.wikipedia.org/wiki/FIPS_140). In FIPS-compliant environments it disables encryption algorithms that are known to be vulnerable, like md5 (Please refer to "Collision vulnerabilities" here https://en.wikipedia.org/wiki/MD5).

Most high-compliance environments that work with data (ie - healthcare, finance, government) require systems and applications to be FIPS-enabled. In order for applications to successfully run in a FIPS-enabled environment, they must use only approved cryptographic algorithms (ie - sha256, aes, rsa, etc...). I've submitted patches for several open source projects based on our needs to run in these high-compliance environments. Sometimes this can be as simple as changing md5 to sha256, but also depends on how the hashes are used in the project.

I appreciate the feedback on this! I'm not sure how to fully test based on these updates that I've submitted so the implications of my updates will need to be tested and vetted properly. Thanks!

@joelostblom
Copy link
Contributor

Closing since #3291 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants