Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit renamed components for configuration bugs #12163

Open
spencergilbert opened this issue Apr 11, 2022 · 0 comments
Open

Audit renamed components for configuration bugs #12163

spencergilbert opened this issue Apr 11, 2022 · 0 comments
Labels
domain: config Anything related to configuring Vector

Comments

@spencergilbert
Copy link
Contributor

spencergilbert commented Apr 11, 2022

While renaming our gcp_stackdriver sinks I noticed we may not be properly handling the backward compatible configuration properly.

https://github.com/vectordotdev/vector/blob/master/src/sources/prometheus/scrape.rs#L173-L176

vs

https://github.com/vectordotdev/vector/blob/master/src/sinks/prometheus/exporter.rs#L157-L163

Related: serde-rs/serde#1504
Related: #12162 (possibly)

As the backward compatibility is only for the component's type we need to ensure the options are maintained across both names until we can deprecate the older names (which we should do more regularly to avoid these bugs and user/programmer footguns).

cc @jszwedko @tobz

@spencergilbert spencergilbert added the domain: config Anything related to configuring Vector label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: config Anything related to configuring Vector
Projects
None yet
Development

No branches or pull requests

1 participant