Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRD #1657

Closed
Tracked by #1654
victhorbi opened this issue Jan 9, 2025 · 2 comments · Fixed by #1704
Closed
Tracked by #1654

NRD #1657

victhorbi opened this issue Jan 9, 2025 · 2 comments · Fixed by #1704
Assignees
@claytonneal
Milestone
1.0.0

Comments

@victhorbi
Copy link
Collaborator

No description provided.

@victhorbi victhorbi mentioned this issue Jan 9, 2025
Open
33 tasks
@victhorbi victhorbi added this to the 1.0.0 milestone Jan 9, 2025
@claytonneal claytonneal self-assigned this Jan 16, 2025
@claytonneal
Copy link
Member

Updating this function name causes KMS adapter build to fail - it would mean a version change to rename it
For now ive updated the doc comment of the function to align with what it does

@claytonneal claytonneal mentioned this issue Jan 16, 2025
Merged
13 tasks
@claytonneal claytonneal mentioned this issue Jan 16, 2025
Merged
12 tasks
@claytonneal
Copy link
Member

Commit for changes: 15e6db1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claytonneal claytonneal

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

chore: update doc comment vechain/vechain-sdk-js
2 participants
@claytonneal @victhorbi