Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewConnection has code block that does nothing #33

Open
joonas-fi opened this issue Apr 26, 2024 · 0 comments
Open

NewConnection has code block that does nothing #33

joonas-fi opened this issue Apr 26, 2024 · 0 comments

Comments

@joonas-fi
Copy link

go/varlink/connection.go

Lines 298 to 304 in 38f589f

switch protocol {
case "unix":
break
case "tcp":
break
}

This doesn't seem to do anything? Each case branch is essentially no-op (contains bare break), yet contains no default branch which could have implemented validating protocol to have valid values (unix, tcp)..

The block is confusing 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant