Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Valora] Reduce number of not needed requests to attestation services #719

Closed
i1skn opened this issue Dec 11, 2020 · 0 comments
Closed

[Valora] Reduce number of not needed requests to attestation services #719

i1skn opened this issue Dec 11, 2020 · 0 comments
Labels
stale An issue that might be irrelevant wallet

Comments

@i1skn
Copy link
Contributor

i1skn commented Dec 11, 2020

In celo-org/celo-monorepo#5925 we added support for 8 digit codes for verification. It introduces a 30% chance of asking the wrong validators for the full attestation code.

Improved solution

We fetch all the attestations (not only active) and take their id mod 10 instead of address of attestation issuer mod 10. In this case would only have a collision if user have more than 10 - completed attestations active attestations at the same time.

Reference: https://discord.com/channels/600834479145353243/732977310101405736/780918327072915456

@i1skn i1skn changed the title Reduce number of not needed requests to attestation services [Valora] Reduce number of not needed requests to attestation services Dec 11, 2020
@MuckT MuckT transferred this issue from celo-org/celo-monorepo Jul 6, 2021
@MuckT MuckT added the wallet label Jul 7, 2021
@silasbw silasbw added the stale An issue that might be irrelevant label Jan 10, 2023
@silasbw silasbw closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale An issue that might be irrelevant wallet
Projects
None yet
Development

No branches or pull requests

3 participants