New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The regular expression to detect phone numbers for es-CO must be changed #1519

Closed

olayadev opened this issue Nov 12, 2020 · 3 comments · Fixed by #1541

Labels

🐛 bug help needed

olayadev commented Nov 12, 2020

My cell phone number starts like this + 573011140XXX, the regex must be changed to admit after the fourth number values from 0-9 and not 2-9. I don't suppose it would work for national landlines either.

olayadev added the 🐛 bug label

Member

ezkemboi commented Nov 20, 2020

@andrefedev, I will take a look at this one.

profnandaa added the help needed label

Member

ezkemboi commented Nov 30, 2020

@andrefedev please take a look at this wikipedia material and update these changes. It will help others.
I have made a PR to make the updates.

ezkemboi mentioned this issue

fix: update es-Co phone number #1541

Merged

3 tasks

profnandaa closed this as completed in #1541

Author

olayadev commented Dec 8, 2020

Great job my brother @ezkemboi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment