Skip to content

Commit

Permalink
fix: remove no longer needed z-index for root menu-bar items (#7743) (#…
Browse files Browse the repository at this point in the history
…7747)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
  • Loading branch information
vaadin-bot and web-padawan authored Sep 3, 2024
1 parent 8c6202b commit 5415d48
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
5 changes: 0 additions & 5 deletions packages/menu-bar/src/vaadin-lit-menu-bar-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ class MenuBarButton extends Button {
:host([slot='overflow']) {
margin-inline-end: 0;
}
[part='label'] ::slotted(vaadin-menu-bar-item) {
position: relative;
z-index: 1;
}
`,
];
}
Expand Down
5 changes: 0 additions & 5 deletions packages/menu-bar/src/vaadin-menu-bar-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ registerStyles(
:host([slot='overflow']) {
margin-inline-end: 0;
}
[part='label'] ::slotted(vaadin-menu-bar-item) {
position: relative;
z-index: 1;
}
`,
{ moduleId: 'vaadin-menu-bar-button-styles' },
);
Expand Down
7 changes: 0 additions & 7 deletions packages/menu-bar/test/menu-bar.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,13 +348,6 @@ describe('item components', () => {
expect(buttons[4].item.component.children.length).to.equal(0);
expect(buttons[4].item.component.textContent).to.equal('Item 5');
});

it('should set position and z-index on the item component to allow clicks', () => {
const item = buttons[2].firstChild;
const style = getComputedStyle(item);
expect(style.position).to.equal('relative');
expect(Number(style.zIndex)).to.equal(1);
});
});

describe('menu-bar in flex', () => {
Expand Down

0 comments on commit 5415d48

Please sign in to comment.