Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANIFEST entries to support Liferay's OSGi container #7024

Closed
vaadin-bot opened this issue Aug 5, 2015 · 4 comments
Closed

Add MANIFEST entries to support Liferay's OSGi container #7024

vaadin-bot opened this issue Aug 5, 2015 · 4 comments
Milestone

Comments

@vaadin-bot
Copy link
Collaborator

Originally by sammso


Add MANIFEST entries to support Liferay 7's OSGi container.

At least following entries should be added.

javax.portlet;version="[2.0,3)";resolution:=optional
javax.portlet.filter;version="[2.0,3)";resolution:=optional
com.liferay.portal.kernel.util;resolution:=optional


Imported from https://dev.vaadin.com/ issue #18561

@vaadin-bot
Copy link
Collaborator Author

Originally by @hesara


Adding these should be easy, but one thing we need to check first: does it cause complications when Vaadin is used via p2 (e.g. in Eclipse plug-ins) - see https://chamibuddhika.wordpress.com/2011/06/04/dangers-of-resolutionoptional/ .

@vaadin-bot
Copy link
Collaborator Author

Originally by sammso


Liferay's point of view import entries does not have be optional.

I did test this with 7.5.1

sammso@2746f9b

@vaadin-bot
Copy link
Collaborator Author

Originally by @hesara


My point was that "optional" (which is logically correct here) is not "optional enough" in some cases, as p2 by default also bundles some optional dependencies. This is really a p2 problem rather than an OSGi problem. However, after discussing this with John, it looks like optional is ok so we can add these and then make changes to our tycho/p2 builds if it causes problems.

@vaadin-bot
Copy link
Collaborator Author

Originally by @hesara


Change waiting for review: https://dev.vaadin.com/review/#/c/11764/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant