From 889a37548d0abd634efc26d1d1396608897a3a52 Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Wed, 15 Jan 2025 11:06:36 +0400 Subject: [PATCH 1/2] feat: add feature flag for focusable disabled components --- .../src/main/java/com/vaadin/experimental/FeatureFlags.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java b/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java index 4f5dc2521f4..2f1c3cdd8d7 100644 --- a/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java +++ b/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java @@ -99,6 +99,10 @@ public class FeatureFlags implements Serializable { "React 19 (default in Vaadin 25)", "react19", "https://react.dev/blog/2024/12/05/react-19", true, null); + public static final Feature FOCUSABLE_DISABLED_COMPONENTS = new Feature( + "Focusable disabled components", "focusableDisabledComponents", + "https://github.com/vaadin/web-components/issues/4585", true, null); + private List features = new ArrayList<>(); File propertiesFolder = null; @@ -128,6 +132,7 @@ public FeatureFlags(Lookup lookup) { features.add(new Feature(DASHBOARD_COMPONENT)); features.add(new Feature(CARD_COMPONENT)); features.add(new Feature(REACT19)); + features.add(new Feature(FOCUSABLE_DISABLED_COMPONENTS)); loadProperties(); } From 4c03c0b9992359c334fd470e1b192b145122a04d Mon Sep 17 00:00:00 2001 From: Sergey Vinogradov Date: Fri, 17 Jan 2025 15:06:40 +0400 Subject: [PATCH 2/2] rename feature flag --- .../src/main/java/com/vaadin/experimental/FeatureFlags.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java b/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java index 2f1c3cdd8d7..98df1151e77 100644 --- a/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java +++ b/flow-server/src/main/java/com/vaadin/experimental/FeatureFlags.java @@ -99,8 +99,8 @@ public class FeatureFlags implements Serializable { "React 19 (default in Vaadin 25)", "react19", "https://react.dev/blog/2024/12/05/react-19", true, null); - public static final Feature FOCUSABLE_DISABLED_COMPONENTS = new Feature( - "Focusable disabled components", "focusableDisabledComponents", + public static final Feature ACCESSIBLE_DISABLED_BUTTONS = new Feature( + "Accessible disabled buttons", "accessibleDisabledButtons", "https://github.com/vaadin/web-components/issues/4585", true, null); private List features = new ArrayList<>(); @@ -132,7 +132,7 @@ public FeatureFlags(Lookup lookup) { features.add(new Feature(DASHBOARD_COMPONENT)); features.add(new Feature(CARD_COMPONENT)); features.add(new Feature(REACT19)); - features.add(new Feature(FOCUSABLE_DISABLED_COMPONENTS)); + features.add(new Feature(ACCESSIBLE_DISABLED_BUTTONS)); loadProperties(); }