Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New architecture support #132

Open
younes0 opened this issue May 9, 2024 · 24 comments
Open

New architecture support #132

younes0 opened this issue May 9, 2024 · 24 comments

Comments

@younes0
Copy link

younes0 commented May 9, 2024

Currently, the library doesn't support React Native new Architecture. The following exception is thrown:

 com.facebook.react.common.JavascriptException: Error: Exception in HostObject::get for prop 'RNUxcam':  
 com.facebook.react.internal.turbomodule.core.TurboModuleInteropUtils$ParsingException: Unable to parse @ReactMethod  
 annotations from native module: RNUxcam```
@Splanis
Copy link

Splanis commented May 22, 2024

+1

@gabrieluxcam
Copy link

Hello @younes0 @Splanis thanks for bringing this up, we will prioritize this before our next update and let you know asap.

@Splanis
Copy link

Splanis commented Jun 11, 2024

any update on this? its the only lib in our app that doesn't support the new architecture :(

@gabrieluxcam
Copy link

Hello @Splanis we're prioritising this for our tasks and will continue working on shipping an update as soon as possible, apologies for the hassle this my cause, we will let you know as soon as there's an update available.

@Manikandan-saminathan
Copy link

Manikandan-saminathan commented Oct 28, 2024

@gabrieluxcam Any update on this? the react native stable version also released.

@gabrieluxcam
Copy link

Hello @Manikandan-saminathan @Splanis @younes0 apologies for the delayed response, React Native UXCam SDK version 6.0.0 supports the RN new architecture, could you try and confirm? Thanks

@Manikandan-saminathan
Copy link

Manikandan-saminathan commented Oct 28, 2024

Hello @Manikandan-saminathan @Splanis @younes0 apologies for the delayed response, React Native UXCam SDK version 6.0.0 supports the RN new architecture, could you try and confirm? Thanks

Screenshot_2024-10-28-16-31-46-012_com.github.android.jpg

@gabrieluxcam able to view any update for 6.0.0 can please confirm once again

@Manikandan-saminathan
Copy link

@gabrieluxcam React Native UXCam SDK version 6.0.0 facing the below build issue
image

@gabrieluxcam
Copy link

Hello @Manikandan-saminathan we're seeing similar issue affecting other SDKs with both React Native versions 0.76 and 0.75, would it be possible at all to test with 0.74 and confirm if the build issue still persists?

Thanks.

Similar issue link here

@Manikandan-saminathan
Copy link

@gabrieluxcam In React Native version 0.76, the new arch technology is enabled by default. We plan to migrate to version 0.76.0, but due to the UX Cam build issue, we are currently blocked from proceeding with the migration.

@gabrieluxcam
Copy link

Hello @Manikandan-saminathan could you elaborate a bit there, I unfortunately didn't understand.

You are using 0.76 but are you unable to test if downgrading the error persists?

Our team will continue checking this and get back to you asap.

@Manikandan-saminathan
Copy link

Hello @gabrieluxcam, thank you for following up! We’re planning to migrate our app to React Native version 0.76.0, which enables the new architecture by default. However, we’re experiencing a build issue specifically with UX Cam in this new architecture.

To clarify, we’re currently on an older React Native version, and we’re blocked from upgrading until this compatibility issue with UX Cam is resolved. We haven’t tried downgrading React Native since the goal is to proceed with version 0.76.0 and beyond. Any insights or fixes would be greatly appreciated.

Thank you!

@Manikandan-saminathan
Copy link

@gabrieluxcam Any update on this ?

@gabrieluxcam
Copy link

Hello @Manikandan-saminathan I unfortunately have no updates yet as this particular issue seems to be external to the SDK, we're reviewing details to see if there's any changes we can make and will update you asap. Thanks!

@ziga-hvalec
Copy link

ziga-hvalec commented Nov 25, 2024

Any update with this. For use uxcam is now the only dependency that doesn't work with new arch or with 0.76

Edit: sorry. it does run with 0.76. just not with new acrh enabled

@Splanis
Copy link

Splanis commented Dec 3, 2024

any progress on this? It doesn't run yet on the new architecture...

@Manikandan-saminathan
Copy link

gabrieluxcam any update on this ?

@gabrieluxcam
Copy link

Hello @Manikandan-saminathan @Splanis @ziga-hvalec apologies for the delay. We've now replicated and fixed this and are on the testing phase for our updated SDK, which is aimed for this upcoming Tuesday, I will update this thread as soon as it released, thanks for your patience.

@laillatoyumi
Copy link

@gabrieluxcam any update on this? We've been waiting a long time to confirm if this has been fixed.

@gabrieluxcam
Copy link

Hello @laillatoyumi this should be fixed and available for you on the UXCam plugin version 6.0.2, could you give it a try and let us know? Thanks

@Felipe-Emanuel
Copy link

I'm currently on 6.0.2. I can start my UXCam, but if I try RNUxcam.logEvent, I got a crash on my app

@gabrieluxcam
Copy link

Hey @Felipe-Emanuel could you please share the crash log? Is it on Android, iOS or both? Thanks.

Also if possible to send a snippet of the logEvent and a sample of the event values you're passing, would be great.

@simonronec
Copy link
Contributor

simonronec commented Feb 6, 2025

@Felipe-Emanuel same here, happens only on Android

Edit: Looks like I've found a fix... use this patch

diff --git a/node_modules/react-native-ux-cam/android/src/main/java/com/uxcam/RNUxcamModuleImpl.java b/node_modules/react-native-ux-cam/android/src/main/java/com/uxcam/RNUxcamModuleImpl.java
index 9164bbe..e02e1eb 100644
--- a/node_modules/react-native-ux-cam/android/src/main/java/com/uxcam/RNUxcamModuleImpl.java
+++ b/node_modules/react-native-ux-cam/android/src/main/java/com/uxcam/RNUxcamModuleImpl.java
@@ -406,6 +406,7 @@ public class RNUxcamModuleImpl {
                     switch (type) {
                         case Null:
                             convertedProperties.put(key, "");
+                            break;
                         case Boolean:
                             convertedProperties.put(key, properties.getBoolean(key));
                             break;

@gabrieluxcam
Copy link

@simonronec Thank you so much for submitting this PR, our team has now included it and just now we have released a new update to the React Native UXCam SDK (version 6.0.3) including it.

Thank you again and please let us know if anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants