-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrubber POC #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! only required change is a Windows line ending issue fix
async function scrubFile( | ||
filePath: string, | ||
tags: TagNameToAction, | ||
isDryRun: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is helpful 🔥
await scrubber.parseConfig("scrubber/scrubberConfig.json"); | ||
await scrubber.start(actions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm my understanding, default tag settings go in the config file, and results from CLI user prompts are passed as the actions
argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that is how it is currently set up.
Alternatively we can just pass all tags through the function and not put any in the config. Thoughs? @alexguo8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI handles default arguments so if that would reduce the complexity of the code by a lot then I agree we can just pass all tags through the CLI
However both are fine for me
Oh additional question, are we handling comments preceding tags here or in a separate PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Notion ticket link
Bootsrap CLI - POC of scrubber
Implementation description
Steps to test
test
file inscrubber/test_dir/
and verify lines to be removedyarn dev
What should reviewers focus on?
Checklist