Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error exposes information about your system #36

Open
aLemonFox opened this issue Sep 27, 2022 · 1 comment
Open

Error exposes information about your system #36

aLemonFox opened this issue Sep 27, 2022 · 1 comment

Comments

@aLemonFox
Copy link

When opening a file that doesn't exist on disk, an error is thrown. This error exposes information about your system. Not sure if this is intended or a side-effect of some logging. I'm not sure which other erros also expose related information. Perhaps good to look into / be aware of.

E.g:

const file = new h5wasm.File("nonexistent.h5", "r");
#000: /home/brian/dev/libhdf5-wasm/wasm_build/1_12_1/_deps/hdf5-src/src/H5F.c line 620 in H5Fopen(): unable to open file
// My name is not Brian, but yours is :)
@bmaranville
Copy link
Member

Eventually I will figure out how to build this efficiently using GH actions, but that just moves the problem around... instead leaking information about that build environment instead of mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants