Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken circleSquare with newer Gmsh #794

Merged
merged 17 commits into from
Apr 20, 2021
Merged

Fix broken circleSquare with newer Gmsh #794

merged 17 commits into from
Apr 20, 2021

Conversation

guyer
Copy link
Member

@guyer guyer commented Apr 13, 2021 •
edited
Loading

Fixes #792

@guyer
Copy link
Member Author

guyer commented Apr 15, 2021

Remaining failures are unrelated to issue #792:

@guyer guyer requested review from tkphd and wd15 April 15, 2021 16:20
tkphd
tkphd approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoothing an awful lot LGTM

@guyer guyer mentioned this pull request Apr 18, 2021
Closed
@guyer
Copy link
Member Author

guyer commented Apr 19, 2021

A better picture of the test status can be seen in the integration tests at #799

tkphd
tkphd approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks pass in #799. Looks good to go.

@guyer guyer merged commit 26b0e91 into usnistgov:master Apr 20, 2021
@guyer guyer deleted the circleSquare_broken branch April 20, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd tkphd approved these changes

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
bug meshes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

circleQuad example fails with Gmsh > 4.4
2 participants
@guyer @tkphd