-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop divide by zero warning in LU solvers #790
Conversation
Stop the divide by zero warning in LU solvers by rearranging the tolerance check.
Test failures seem unrelated to changes |
shell.nix
Outdated
@@ -31,7 +31,12 @@ in | |||
|
|||
export OMPI_MCA_plm_rsh_agent=/usr/bin/ssh | |||
|
|||
## To build the docs | |||
## To build the docs (don't use --pure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go in #791?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
VTK failure on Travis is probably version incompatibility with Numpy. |
I agree, the VTK errors are safe to ignore |
I don't understand why the polyxtal example is stalling with SciPy on Py3k |
Is this the first time you've seen that? |
I can't remember a stall like this for a serial run. I was wondering if the error was somehow negative, so that the |
Not to worry. I'll try and debug it at some point. No rush to finish this. |
polyxtal is stalling with SciPy on other branches. This doesn't have anything to do with it. |
@guyer I merged from master and tests are failing for various reasons seemingly not related to the changes. |
Weird. Looks like a slew of unrelated failures. Should be a joy to debug. |
Looks like a lot of things started failing about 5 months ago when I relaxed the installation constraint on Gmsh from |
Prompted by this.