Assorted fixes while supporting PETSc #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Terminate sweeps if they go too long this example could run forever if the solver doesn't converge - clean up messy doctest structure - Remove litter from tests Tests should not pollute user directories with temp files - Import math from numerix numerix routines are no longer imported globally. Horrible construction of chemotaxis tests meant we didn't catch these two. - Change chemotaxis examples into proper doctests - Disable archaic tests - disable examples/cahnHilliard/mesh2DCoupled tests - disable `levelSet/electroChem` tests These tests have [all kinds of problems](usnistgov#682) - Fix formatting of results
Fix timetests formatting
- Some combination of linux and Python 3.8 fails to close /dev/null on other processors. - Writing on only one file deadlocks in `fipy.meshes.representations.gridRepresentation._GridRepresentation._test`: https://app.circleci.com/jobs/github/usnistgov/fipy/1226 https://app.circleci.com/jobs/github/usnistgov/fipy/1225 https://app.circleci.com/jobs/github/usnistgov/fipy/1217 https://travis-ci.org/usnistgov/fipy/jobs/627999300 - Stipulate binary Avoid doubling memory with `dumps()`, but prevent `/dev/null` closure problem
- Limit Gmsh to < 4.0 Gmsh 4.0 doesn't partition correctly Addresses usnistgov#697 - Export ghosts with Gmsh 4.x [Ghosts are broken](https://gitlab.onelab.info/gmsh/gmsh/issues/733), but export them anyway. - Change refinement metric - Limit refinements Gmsh refinement seems to stall out - Don't partition tiny meshes - Tolerate mangled Gmsh version string Assume Gmsh 3.0 if we can't parse the useless nonsense that Gmsh stuffs into stderr - Ensure GmshMesh uses correct communicator More than one overlap will "downgrade" to a serial communicator because Gmsh doesn't give us more than one layer of ghosts
5946f8c to
f71f15b
Compare
wd15
reviewed
Jan 27, 2020
wd15
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.