Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Nick Croft's thesis #681

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Dec 17, 2019

Nick Croft's thesis link is updated and fixed (couldn't find a
DOI). Excessive white space also removed from refs.bib.

Nick Croft's thesis link is updated and fixed (couldn't find a
DOI). Excessive white space also removed from refs.bib.
@wd15 wd15 requested review from guyer and tkphd December 17, 2019 16:50
@tkphd
Copy link
Contributor

tkphd commented Dec 17, 2019

The Greenwich Academy page indicates that the provided link is a URI, which should be equivalent to a DOI. The thesis also has a British Library EThOS record: uk.bl.ethos.245782, from which the Greenwich Academy's URI is linked.

I think the URI is the better link, since it goes directly to a downloadable artifact, though the EThOS link may be longer-lived.

Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@guyer guyer merged commit dfb086f into usnistgov:master Jan 25, 2020
@wd15 wd15 deleted the fix-croft-thesis-link branch February 10, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants