gmshMesh.py compatibility with Gmsh > 3.0.6 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gmshMesh.py for compatibility with Gmsh version > 3.0.6
guyer
approved these changes
Apr 23, 2019
|
CircleCI didn't run for some reason. I'm merging anyway. |
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Serial only. Must stipulate bandwidth in all uses. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
There was a lot of redundant code between the specified solver cases and the guessing solver cases. These treatements have been consolidated and simplified. Easier to rearrange order of solvers to try and to add in new solvers. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Old `parallelComm` made heavy assumptions about availability of Trilinos. Comms (particularly the parallel ones) are intimately tied to the solver in use, so they should be instantiated with the solver. No matter what, we need mpi4py, so use it (and only it) to determine number of processes in order to pick a solver. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Based on trilinos' comms Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
PETSc seems pickier about matrices with nothing on the diagonal than the other solvers. This `DummySolver` is an attempt to work around that, although I'm not clear what the `DummySolver` is attempting to resolve in the first place. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Not used and no longer importable at this stage. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Matrices and vectors have already been converted by the time we get to `_solve_()`. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
There is no point in passing the iterations and tolerance to `PETSc.KSP()`. It is ony used to precondition. We need to handle iterations and tolerance ourselves, just like for the other LU solvers. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
Incomplete transition to parallel. Works for some (`examples/diffusion/mesh1D.py`, `examples/diffusion/mesh20x20.py`), but not others (`examples/diffusion/circle.py`). Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jul 3, 2019
PETSc's LinearLUSolver presently doesn't converge, causing this example to run forever. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Serial only. Must stipulate bandwidth in all uses. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
There was a lot of redundant code between the specified solver cases and the guessing solver cases. These treatements have been consolidated and simplified. Easier to rearrange order of solvers to try and to add in new solvers. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Old `parallelComm` made heavy assumptions about availability of Trilinos. Comms (particularly the parallel ones) are intimately tied to the solver in use, so they should be instantiated with the solver. No matter what, we need mpi4py, so use it (and only it) to determine number of processes in order to pick a solver. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Based on trilinos' comms Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
PETSc seems pickier about matrices with nothing on the diagonal than the other solvers. This `DummySolver` is an attempt to work around that, although I'm not clear what the `DummySolver` is attempting to resolve in the first place. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Not used and no longer importable at this stage. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Matrices and vectors have already been converted by the time we get to `_solve_()`. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
There is no point in passing the iterations and tolerance to `PETSc.KSP()`. It is ony used to precondition. We need to handle iterations and tolerance ourselves, just like for the other LU solvers. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
Incomplete transition to parallel. Works for some (`examples/diffusion/mesh1D.py`, `examples/diffusion/mesh20x20.py`), but not others (`examples/diffusion/circle.py`). Addresses usnistgov#644
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Dec 16, 2019
PETSc's LinearLUSolver presently doesn't converge, causing this example to run forever. Addresses usnistgov#644
guyer
added a commit
to guyer/fipy-feedstock
that referenced
this pull request
Jan 2, 2020
Thanks to usnistgov/fipy#644, newer versions of Gmsh should be fine
5 tasks
guyer
added a commit
to conda-forge/fipy-feedstock
that referenced
this pull request
Jan 2, 2020
* Restore gmsh on all platforms Thanks to usnistgov/fipy#644, newer versions of Gmsh should be fine * Bump build number * Drop gmsh on Win2k
guyer
added a commit
to guyer/fipy
that referenced
this pull request
Jan 27, 2020
There was a lot of redundant code between the specified solver cases and the guessing solver cases. These treatements have been consolidated and simplified. Easier to rearrange order of solvers to try and to add in new solvers. Addresses usnistgov#644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gmshMesh.py for compatibility with Gmsh version > 3.0.6