Remove incorrect axis argument to concatenate
#477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This never should have worked, but numpy 1.10 actually checks. Also provide some documentation for what `_faceToCellDistanceRatio` is and why it's scalar. Addresses #475
|
Don't merge, yet. Needs to be integrated with #472 |
pkgw
added a commit
to pkgw/fipy
that referenced
this pull request
Dec 9, 2015
…() calls As far as I can tell, there were several codepaths in the UniformGrid3D class that seemed not to have been tested since they didn't work at all; in particular, the _cellToCellIDs map was broken. This commit fixes that (I hope) and a couple of more invalid `axis=n` keywords to `numerix.concatenate()`. Unfortunately I have not put together test cases for these problems, so I'm not completely sure that the "fixed" _cellToCellIDs is always correct. See issue usnistgov#470, issue usnistgov#475, and issue usnistgov#477.
guyer
pushed a commit
that referenced
this pull request
Dec 27, 2015
…() calls As far as I can tell, there were several codepaths in the UniformGrid3D class that seemed not to have been tested since they didn't work at all; in particular, the _cellToCellIDs map was broken. This commit fixes that (I hope) and a couple of more invalid `axis=n` keywords to `numerix.concatenate()`. Unfortunately I have not put together test cases for these problems, so I'm not completely sure that the "fixed" _cellToCellIDs is always correct. See issue #470, issue #475, and issue #477.
|
Oops. Comments were still worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never should have worked, but numpy 1.10 actually checks.
Also provide some documentation for what
_faceToCellDistanceRatiois andwhy it's scalar.
Addresses #475