Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neumann boundary conditions not clearly documented #382

Closed
guyer opened this issue Sep 19, 2014 · 5 comments
Closed

Neumann boundary conditions not clearly documented #382

guyer opened this issue Sep 19, 2014 · 5 comments

Comments

@guyer
Copy link
Member

guyer commented Sep 19, 2014

As discussed in http://thread.gmane.org/gmane.comp.python.fipy/3035, the wiki page on BoundaryConditions does not accurately describe the Neumann case. The [http://www.ctcms.nist.gov/fipy/documentation/USAGE.html#applying-fixed-gradient-boundary-conditions-neumann official documentation] is better, but still doesn't explain how to specify a magnitude for the normal flux.

  • The wiki page should be corrected or removed

  • The documentation should address how to get the normal

  • The mesh._faceNormals property should be made public if users are expected to use it

    Imported from trac ticket #639, created by guyer on 04-30-2013 at 10:12, last modified: 09-11-2013 at 18:02

@fipymigrate
Copy link

In 9ee09e7:

#CommitTicketReference repository="fipy" revision="9ee09e7548a36e5659f182a4cd74a98979f02ef8"
Rename `_faceNormals` to `faceNormals`

Addresses issue #382

Trac comment by Jonathan Guyer guyer@nist.gov on 09-09-2013 at 23:48

@fipymigrate
Copy link

In 101b968:

#CommitTicketReference repository="fipy" revision="101b968052d2d1dccbc162869d2c1f1c763a988f"
Document normal gradient constraint

Addresses issue #382

Trac comment by Jonathan Guyer guyer@nist.gov on 09-09-2013 at 23:48

@guyer
Copy link
Member Author

guyer commented Sep 19, 2014

wiki updated.

Pull request:


The following changes since commit aee8dc996362574344c5a7620b87fb8db50b95e7:

  Merge branch 'ticket653-enable_google_analytics' into develop (2013-09-06 12:01:56 -0400)

are available in the git repository at:


  ssh://git@code.matforge.org/nist/fipy.git ticket639-Neumann_boundary_conditions_not_clearly_documented

for you to fetch changes up to 101b968052d2d1dccbc162869d2c1f1c763a988f:

  Document normal gradient constraint (2013-09-09 23:41:06 -0400)

----------------------------------------------------------------
Jonathan Guyer (2):
Rename `_faceNormals` to `faceNormals`
Document normal gradient constraint

 documentation/USAGE.txt                    |  5 +++++
 fipy/meshes/abstractMesh.py                | 13 +++++++++----
 fipy/meshes/cylindricalNonUniformGrid2D.py |  4 ++--
 fipy/meshes/cylindricalUniformGrid1D.py    |  2 +-
 fipy/meshes/cylindricalUniformGrid2D.py    |  4 ++--
 fipy/meshes/mesh.py                        | 20 ++++++++++----------
 fipy/meshes/mesh2D.py                      |  8 ++++----
 fipy/meshes/nonUniformGrid2D.py            |  2 +-
 fipy/meshes/nonUniformGrid3D.py            |  2 +-
 fipy/meshes/periodicGrid1D.py              |  2 +-
 fipy/meshes/periodicGrid2D.py              |  2 +-
 fipy/meshes/tri2D.py                       |  2 +-
 fipy/meshes/uniformGrid.py                 |  4 ++--
 fipy/meshes/uniformGrid1D.py               |  6 +++---
 fipy/meshes/uniformGrid2D.py               |  8 ++++----
 fipy/meshes/uniformGrid3D.py               |  8 ++++----
 fipy/terms/abstractDiffusionTerm.py        |  2 +-
 fipy/terms/diffusionTermNoCorrection.py    |  2 +-
 18 files changed, 53 insertions(+), 43 deletions(-)

Trac comment by guyer on 09-09-2013 at 23:53

@fipymigrate
Copy link

In 2cdff73:

#CommitTicketReference repository="fipy" revision="2cdff73ca19a5c77599fdbd8324edd09119c6a5a"
Merge branch 'develop' into ticket639-Neumann_boundary_conditions_not_clearly_documented

Addresses issue #382

Trac comment by Daniel Wheeler daniel.wheeler2@gmail.com on 09-11-2013 at 18:02

@fipymigrate
Copy link

In cba2d83:

#CommitTicketReference repository="fipy" revision="cba2d83b85e492d292a7f82eb6765a8bf2f14a30"
Merge branch 'ticket639-Neumann_boundary_conditions_not_clearly_documented' into develop

Fixes issue #382

Trac comment by Daniel Wheeler daniel.wheeler2@gmail.com on 09-11-2013 at 18:02

@guyer guyer closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants